[Development] Qt 5.5.0 header diff: QtMultimedia.diff

[Marc Mutz]

On Friday 05 June 2015 10:10:52 Frederik Gladhorn wrote:
> +    typedef QPair<qreal, qreal> FrameRateRange;

Should be a struct, not a QPair:

   FrameRateChange chg = ...;
   chg.first... // what's first???
   chg.second... // what's second???

>      enum Status {
>          UnavailableStatus,
>          UnloadedStatus,
> @@ -169,6 +172,21 @@ public:
>      void setViewfinder(QGraphicsVideoItem *viewfinder);
>      void setViewfinder(QAbstractVideoSurface *surface);
>  
> +    QCameraViewfinderSettings viewfinderSettings() const;
> +    void setViewfinderSettings(const QCameraViewfinderSettings &settings);
> +
> +    QList<QCameraViewfinderSettings> supportedViewfinderSettings(
> +            const QCameraViewfinderSettings &settings =
> QCameraViewfinderSettings()) const;

QCameraViewFinderSettings isn't marked as movable, so should be held in 
QVector instead.

> +    QList<QSize> supportedViewfinderResolutions(
> +            const QCameraViewfinderSettings &settings =
> QCameraViewfinderSettings()) const;

QList<QSize> should be QVector<QSize>


> +    QList<FrameRateRange> supportedViewfinderFrameRateRanges(
> +            const QCameraViewfinderSettings &settings =

QList<FrameRateChange> should be QVector<FrameRateChange>

> QCameraViewfinderSettings()) const; +
> +    QList<QVideoFrame::PixelFormat> supportedViewfinderPixelFormats(
> +            const QCameraViewfinderSettings &settings =
> QCameraViewfinderSettings()) const;

QList<PixelFormat> should be QVector<PixelFormat> (enum PixelFormat)

Thanks,
Marc

-- 
Marc Mutz <marc.mutz at kdab.com> | Senior Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
Tel: +49-30-521325470
KDAB - The Qt Experts