[Development] QAtomicInteger default implementations

Thiago Macieira thiago.macieira at intel.com
Tue Jun 23 18:18:03 CEST 2015


On Tuesday 23 June 2015 19:07:12 Marc Mutz wrote:
> On Tuesday 23 June 2015 15:12:36 Mike Krus wrote:
> > Hi
> > 
> > while investigating crashes in QAtomicInteger<quint64> on iOS, I was
> > wondering why the default is not the use the C++11 implementation if it’s
> > available? In particular, in qbasicatomic.h, the asm-based implementations
> > are preferred for all arm platforms (and others). Shouldn’t the version
> > using std::atomic be preferred?
> 
> Doing so would be binary incompatible. (Contested) rationale here:
> https://codereview.qt-project.org/103848

Some (like me) argued and argue that it's not binary incompatible. It's an ODR 
violation, but all of our minor releases have contained ODR violations for 20 
years.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center




More information about the Development mailing list