[Development] No Change-Id being generated for commit message

Mandeep Sandhu mandeepsandhu.chd at gmail.com
Thu Mar 26 02:53:18 CET 2015


>
> Is git stripspace or grep malfuncitoning?

'git stripspace' seems to be working fine.

$ cat COMMIT_EDITMSG | git stripspace

<produces contents of COMMIT_EDITMSG>

Although the commit-msg script seems to be exiting early in add_ChangeId()...

<snip>

MSG="$1"

# Check for, and add if missing, a unique Change-Id
#
add_ChangeId (){
    clean_message=`sed -e '
        /^diff --git a\/.*/{
            s///
            q
        }
        /^Signed-off-by:/d
        /^#/d
    ' "$MSG" | git stripspace`
    if test -z "$clean_message"
    then
        return
    fi
...
...
</snip>

clean_message turns out to be empty!

I'm not sure, but is that a valid sed expression (with all the
white-spaces in-between)?



> --
> Thiago Macieira - thiago.macieira (AT) intel.com
>   Software Architect - Intel Open Source Technology Center
>
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development



More information about the Development mailing list