[Development] QT_NO_DRAGANDDROP qt 5.6 git build fails

[Samuel Gaist]

On 8 sept. 2015, at 14:36, Gunnar Roth <gunnar.roth at gmx.de> wrote:

> Hello Samuel and Giuseppe 
>  
> i am not capable to create a patch in qt gerrrit. i get an http 403 error as written in an previous mail.
> So maybe one of you could do me the favour and create patches in gerrit for me?
> I made some patch diff files gainst qt 5.6 for this issue and attached them to this mail.
>  
> Regards,
> Gunnar Roth

Hi,

https://codereview.qt-project.org/127023
https://codereview.qt-project.org/127024
https://codereview.qt-project.org/127025
https://codereview.qt-project.org/127026

Note that they are only for to the drag and drop part currently as some of your modifications are related to other matters.

Regards
Samuel


> Gesendet: Mittwoch, 02. September 2015 um 16:06 Uhr
> Von: "Samuel Gaist" <samuel.gaist at edeltech.ch>
> An: "Giuseppe D'Angelo" <giuseppe.dangelo at kdab.com>
> Cc: development at qt-project.org
> Betreff: Re: [Development] QT_NO_DRAGANDDROP qt 5.6 git build fails
> 
> On 2 sept. 2015, at 15:35, Giuseppe D'Angelo <giuseppe.dangelo at kdab.com> wrote:
> 
> > Il 02/09/2015 15:02, Gunnar Roth ha scritto:
> >> If you wonder why i need that, its because of wc2013 it has no DnD
> >> support ( as wec7 had).
> >
> > Submit a patch? :)
> >
> > Unfortunately Qt is not tested in all the possible -no-feature switches.
> >
> > Cheers,
> > --
> > Giuseppe D'Angelo | giuseppe.dangelo at kdab.com | Software Engineer
> > KDAB (UK) Ltd., a KDAB Group company | Tel: UK +44-1625-809908
> > KDAB - The Qt Experts
> >
> 
> +1 for the patch but the problem is rather that QWidget has the corresponding methods surrounded by #ifndef QT_NO_DRAGANDDROP and not QGraphicsView so it would make more sense to do it also for that class and not only for the content of the implementation.
> 
> Cheers
> Samuel
> 
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
> <80_fix_non_dnd_no_clipboard_p0.diff><81_fix_non_dnd_no_clipboard_p1.diff><82_fix_non_dnd_no_clipboard_p2.diff><83_fix_non_dnd_no_clipboard_p3.diff><87_fix_no_dnd_widgets_fix_static.diff>