[Development] Old platform-specific functions

[Sze Howe Koh]

On 16 September 2015 at 15:46, Jake Petroules
<jake.petroules at petroules.com> wrote:
> > On Sep 15, 2015, at 9:07 PM, Sze Howe Koh <szehowe.koh at gmail.com> wrote:
> >
> > Hi all,
> >
> > There's a list of platform-specific functions from Qt 4:
> > http://doc.qt.io/qt-5/exportedfunctions.html
> >
> > It looks like most of these functions are now gone. The non-existing
> > functions should be removed from the documentation, but 3 functions
> > remain in the code base:
> >
> > * qt_mac_secure_keyboard() is marked Q_DEAD_CODE_FROM_QT4_MAC
> > (qlineedit.cpp)
>
>
> Maybe introduce a new function in QPA, exposed through QtMac namespace in
> QtMacExtras?
>
> > * qt_mac_set_dock_menu() is marked QT_DEPRECATED, and is slated for
> > removal in Qt 6 (qmenu.h)
>
>
> Replaced by QMenu::setAsDockMenu
> (http://doc.qt.io/qt-5/qmenu.html#setAsDockMenu)
>
> > * qt_set_sequence_auto_mnemonic() is not marked as dead/deprecated in any
> > way.
>
>
> Maybe introduce a new function on QShortcut that takes an enum (Auto, On,
> Off)?
>
>
> > Should any of these be left in the documentation? (Note that
> > qt_set_sequence_auto_mnemonic() is currently documented as a way to
> > get non-standard behaviour on OS X:
> > http://doc.qt.io/qt-5/qshortcut.html#details )


Thanks for your input, Jake. I'll leave the decision about new
functions to the folks involved in GUI code; I'll just update the
documentation to reflect the current situation:

https://codereview.qt-project.org/127249/
https://codereview.qt-project.org/127250/
https://bugreports.qt.io/browse/QTBUG-48693
https://bugreports.qt.io/browse/QTBUG-48694


Regards,
Sze-Howe