[Development] Commits: Is it possible to add a missed "default" parameters of methods?

Marc Mutz marc.mutz at kdab.com
Tue Jul 26 13:51:19 CEST 2016

On Tuesday 26 July 2016 14:41:25 Denis Shienkov wrote:
> Hi all, Thiago.
> Seems, we (I'am) have missed default parameters for the waitFor() methods
> of QSerialPort:
> * https://codereview.qt-project.org/#/c/165583/
> So, my questions:
> 1. Is it possible just to add of a missed default params and to merge it?

Yes. It's forward- and backwards-BC and backwards-SC.

> 2. If yes, then, what of a branch is makes sense?

dev, since it's not forward-SC (a call omitting the defaulted argument will 
not compile on a version without the default argument).

> BR,
> Denis

Marc Mutz <marc.mutz at kdab.com> | Senior Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
Tel: +49-30-521325470
KDAB - Qt, C++ and OpenGL Experts

More information about the Development mailing list