[Development] commas in ctor-init-lists

[Eskil Abrahamsen-Blomfeldt]

+1 from me as well.

The argument about natural language makes no sense to me;
Nothing in C++ resembles natural grammar, nor should it;
It might take some getting used to,
    like any change in style,
    but after a while you won't think it is ugly anymore,
    and then we can reap the benefits of it being objectively superior
        because it minimizes diffs in initializer lists. :)

--
Eskil Abrahamsen Blomfeldt
Senior Manager, Qt Graphics/Multimedia
The Qt Company
Sandakerveien 116
0484 Oslo, Norway
eskil.abrahamsen-blomfeldt at qt.io<mailto:eskil.abrahamsen-blomfeldt at qt.io>
http://qt.io<http://qt.io/>

From: Development <development-bounces+eskil.abrahamsen-blomfeldt=qt.io at qt-project.org<mailto:development-bounces+eskil.abrahamsen-blomfeldt=qt.io at qt-project.org>> on behalf of Simon Hausmann <Simon.Hausmann at qt.io<mailto:Simon.Hausmann at qt.io>>
Date: Wednesday 1 June 2016 at 14:56
To: Marc Mutz <marc.mutz at kdab.com<mailto:marc.mutz at kdab.com>>, "development at qt-project.org<mailto:development at qt-project.org>" <development at qt-project.org<mailto:development at qt-project.org>>
Subject: Re: [Development] commas in ctor-init-lists

Hi,

I'm in favorof changing our coding style to adopt the model you call "butt ugly" because I find it more appealing and I find that it makes diffs easier to read.

Simon


________________________________
From: Marc Mutz <marc.mutz at kdab.com<mailto:marc.mutz at kdab.com>>
Sent: Jun 1, 2016 14:41
To: development at qt-project.org<mailto:development at qt-project.org>
Subject: [Development] commas in ctor-init-lists

Hi,

There seems to have been a silent underground move to uglify the Qt sources
, by using commas to introduce lines
. I have no idea where this came from
, but it looks butt
-ugly and it is in violation of http
://wiki
.qt
.io
/Qt_Coding_Style

QFoo::QFoo()
  : QBase(),
    m_f1(),
    m_f2()
{

}

-not-

QFoo::QFoo()
  : QBase()
  , m_f1()
  , m_f2()
{

}

(http://wiki.qt.io/Qt_Coding_Style#Line_breaks 2nd item: "Commas go at the
_end_ of wrapped lines")

Thanks,
Marc

--
Marc Mutz <marc.mutz at kdab.com<mailto:marc.mutz at kdab.com>> | Senior Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
Tel: +49-30-521325470
KDAB - Qt, C++ and OpenGL Experts
_______________________________________________
Development mailing list
Development at qt-project.org<mailto:Development at qt-project.org>
http://lists.qt-project.org/mailman/listinfo/development
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20160601/b7a3ee18/attachment.html>