[Development] commas in ctor-init-lists

Martin Smith Martin.Smith at qt.io
Fri Jun 3 10:16:48 CEST 2016


>I am fairly sure he did in fact mean

Eddie, we should write with precision. That's kind of the point of this thread. Some are saying putting the comma on the next line is more precise; some are saying it isn't. But note that you didn't defend my argument the same way you are defending Andre's, yet his reply to me was explicitly absolute, where mine was not.

martin
________________________________________
From: Edward Welbourne
Sent: Friday, June 3, 2016 10:05:52 AM
To: Martin Smith; André Somers; development at qt-project.org
Subject: Re: [Development] commas in ctor-init-lists

I wrote:
>> Please allow that,

Martin:
> I do, of course. Andre didn't. He wrote...

>>> if (blah || boo || foo) {  //no line breaking allowed

> ...with the comment.

I am fairly sure he did in fact mean

  if (somee.really(long.and.complicated, expression) || another.such(that, makes, the.line.too.long) || and.then.some.more())

and that he was, at that point, reading the earlier objection as meaning
we wouldn't be allowed to split this line.  I disagree - our coding
style does allow splitting it as

  if (somee.really(long.and.complicated, expression)
      || another.such(that, makes, the.line.too.long)
      || and.then.some.more())

unless I misunderstood a rule I didn't like - but I'm fairly sure he did
mean to use blah, boo and foo as metasyntactic variables.

Please take a little time to read other folks' contributions charitably,
rather than rushing to find fault with them.

        Eddy.



More information about the Development mailing list