[Development] QtBase WIP branch request

Oswald Buddenhagen oswald.buddenhagen at qt.io
Thu Oct 6 16:10:53 CEST 2016


On Thu, Oct 06, 2016 at 09:32:40PM +0800, Tim Blechmann wrote:
> >> We’re working on an update to the macOS/Cocoa platform plugin,
> >> and I would like to request a WIP branch where the changes can
> >> be finalized:
> >>
> >>    wip/remac
> >>
> > you have Good Reasons (TM) for creating a branch according to
> > https://wiki.qt.io/Branch_Guidelines#Creating_a_new_feature_branch , yes?
> 
> i'm experiencing many of the issues that this branch will address (and
> hacked around them in my own version of the cocoa platform plugin).
> having a branch which is easy to access would allow me test the changes
> in a real-world context.
> 
as the wiki explains, a gerrit review series is also a branch, so you
can just check it out.

the one thing the wiki doesn't mention (but probably should): why do you
want to branch _at all_? i can think of two valid reasons:
- the work is experimental and may end up being discarded wholesale. in
  this case, having it in a separate branch is cleaner than reverts on
  the mainline.
- the development will take a long/unpredictable time, and you don't
  want the unfinished parts to be in mainline for the time being, as per
  feature integration policy.

the one thing that is definitely *not* a good reason: there may be
dysfunctional intermediate states. nope, you don't get to violate
atomicity just because you're on a branch.

of course, if you just want to be sloppy and are fine with a throw-away
branch, all the power to you.

> tia!
> tim
> 
> > mergable or throw-away?
> 
> 
> 
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development



More information about the Development mailing list