[Development] Notes on "Managing Qt's branches" session @ QCS 2016
oswald.buddenhagen at qt.io
Fri Sep 23 11:50:11 CEST 2016
On Thu, Sep 22, 2016 at 09:41:29AM +0200, Marc Mutz wrote:
> On Thursday 22 September 2016 08:55:13 Liang Qi wrote:
> > Give the merge permission to everyone is obiviously not a solution.
> Not everyone, but approvers, maybe? Merges need to be reviewed like any other
> commit, so why are they special, anyway?
because a botched merge push may result in hundreds of bogus reviews
(when somebody does pull --rebase before pushing the merge; no, that's
not a hypothetical situation). not having the right to push merges
trains the users to not even attempt it.
another reason is that some people tend to over-merge, needlessly
cluttering the history. having to ask another person (who will hopefully
critically examine the request) is a natural check for this.
More information about the Development