[Development] QCOMPARE & mixed types

[Milian Wolff]

On Freitag, 21. April 2017 12:10:07 CEST Marc Mutz wrote:
> Hi,
> 
> Jedrzej asked me to raise the issue here.
> 
> Rationale for both allowing, as well as for why I think the rationale for
> the existing ban is wrong, is included in the commit message:
> 
>   https://codereview.qt-project.org/192269

I for one welcome this change. I always cringed when I wrote code such as

    QCOMPARE(getSomeQUint64(), 0)

and it would fail to compile, forcing me to write ugly code such as

    QCOMPARE(getSomeQUint64(), quint64(0))

I've also come across code that failed to compile some platforms, since it 
used something like 0l or 0ll which did not match whatever platform-specific 
type was used on the lhs...

So, from my side a clear +1!
-- 
Milian Wolff | milian.wolff at kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5903 bytes
Desc: not available
URL: <http://lists.qt-project.org/pipermail/development/attachments/20170421/a9381e92/attachment.bin>