[Development] Suggestion to add labels when changing API

Edward Welbourne edward.welbourne at qt.io
Fri Dec 8 14:23:32 CET 2017


On 07/12/2017 17:22, Liang Qi wrote:
>> The changes that are important to be merged up before other changes
>> should have a special tag, such as API_CHANGE in the commit
>> message. Then the script used to do the merges could stop and/or warn
>> about commits with this tag in the message, which would make the
>> merge easier. We can also apply this check into the submodule update
>> script.

Tor Arne Vestbø (8 December 2017 13:41)
> Can't the script detect this by looking for changes to public headers?

That's possible (albeit possibly trickier than you think), but not all
changes to public headers present a problem that this needs to attend
to.  Our API reviews do require actual reviewers, after all.

	Eddy, who has no idea what sync.profile pinning is.



More information about the Development mailing list