[Development] ChangeLog entries and reverted commits

Edward Welbourne edward.welbourne at qt.io
Mon Jul 31 10:52:43 CEST 2017


Joerg Bornemann (31 July 2017 09:07)

> Suppose you create a new feature in commit A for Qt 5.x. The commit
> message has a change log entry. After a while A has to be
> reverted. You won't have time to fix the issue properly for 5.x. The
> git history for 5.x still contains the change log entry - now
> erronously.
>
> Is the script that creates change logs from git commit history aware
> of reverts and filters out such entries?

Good question.  I don't actually know how we generate our change-logs,
but qtqa/src/createchangelog/main.go looks suspiciously likely to be it.
Its extractChangeLog() appears to be parsing out the ChangeLog; its
caller, appMain(), appears to be taking the full list of commits and
scanning each; and the word "revert" never appears.

So I consider it likely that the script doesn't take reverts into
account.  Talk to Simon Hausmann, he's the author,

	Eddy.



More information about the Development mailing list