[Development] Backporting the Keccak change

Thiago Macieira thiago.macieira at intel.com
Tue Sep 5 15:29:44 CEST 2017


On Tuesday, 5 September 2017 05:09:19 -03 Oswald Buddenhagen wrote:
> #  ifndef QT_FIXED_SHA3
>        QT_DEPRECATED_SINCE(5, 10, 0) Sha3_224 = 7,
>        QT_DEPRECATED_SINCE(5, 10, 0) Sha3_256,
>        QT_DEPRECATED_SINCE(5, 10, 0) Sha3_384,
>        QT_DEPRECATED_SINCE(5, 10, 0) Sha3_512,
> #  else

Almost. There are two things there:
 1) I'dl ike people to opt into the broken code, so I think the #if should be 
reversed. It will cause a few support tickets and bug reports, but I think 
it's best this way for the long term. At some point, we'd have to do it 
anyway.

 2) you can't use QT_DEPRECATED or Q_DECL_DEPRECATED on enumerations unless 
__cpp_enumerator_attributes >= 201411

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center




More information about the Development mailing list