[Development] [Qt-creator] [FYI] the new way to retarget gerrit changes

Konstantin Tokarev annulen at yandex.ru
Mon Jan 8 14:48:44 CET 2018



08.01.2018, 16:40, "Oswald Buddenhagen" <oswald.buddenhagen at qt.io>:
> On Mon, Sep 12, 2016 at 02:39:57PM +0300, Orgad Shaneh wrote:
>>     Either extend the sanity bot, or create a new bot, which listens on
>>     gerrit's event stream.
>>     If the change's owner (or an approver?) posts a comment reading "Please
>>     retarget <branch>", run your script on the server side. You need some
>>     sanity test that ensures this branch exists etc...
>
> ... which he implemented, and it's deployed now.
>
> for simplicity, only the change owner may issue the command. for other
> cases, you still need to go through an admin. the same is advisable for
> batch requests, but do as you wish.

I think batch requests should be automated by adding comments via Gerrit's API
(to minimize your distractions)

>
> the regex is
>
>   /^(?:gerrit-)?bot:\h*(?:please\h+)?move\h+(?:back\h+)?to\h+(?:branch\h+)?([\w.]*\w)\b/im
>
> which boils down to "bot: move to <branch>" at the start of any line of
> a gerrit cover message.

Oh, "please" keyword :)

> _______________________________________________
> Qt-creator mailing list
> Qt-creator at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/qt-creator

-- 
Regards,
Konstantin



More information about the Development mailing list