[Development] [Qt-creator] [FYI] the new way to retarget gerrit changes

Konstantin Tokarev annulen at yandex.ru
Mon Jan 8 15:00:36 CET 2018



08.01.2018, 16:51, "Orgad Shaneh" <orgads at gmail.com>:
> On Mon, Jan 8, 2018 at 3:48 PM, Konstantin Tokarev <annulen at yandex.ru> wrote:
>
>> 08.01.2018, 16:40, "Oswald Buddenhagen" <oswald.buddenhagen at qt.io>:
>>> On Mon, Sep 12, 2016 at 02:39:57PM +0300, Orgad Shaneh wrote:
>>>>     Either extend the sanity bot, or create a new bot, which listens on
>>>>     gerrit's event stream.
>>>>     If the change's owner (or an approver?) posts a comment reading "Please
>>>>     retarget <branch>", run your script on the server side. You need some
>>>>     sanity test that ensures this branch exists etc...
>>>
>>> ... which he implemented, and it's deployed now.
>>>
>>> for simplicity, only the change owner may issue the command. for other
>>> cases, you still need to go through an admin. the same is advisable for
>>> batch requests, but do as you wish.
>>
>> I think batch requests should be automated by adding comments via Gerrit's API
>> (to minimize your distractions)
>
> That's exactly what was done. Or did I misread your comment?
>
> All you need to do is add a comment in gerrit saying: "bot: move to 5.10" and you're done.

I mean, there can be additional script on client side, to add this comment to several changes
(if I usderstood "batch request" correctly)

>
> - Orgad


-- 
Regards,
Konstantin



More information about the Development mailing list