[Development] API review request: CBOR Stream reader and writer

Thiago Macieira thiago.macieira at intel.com
Thu Jan 18 16:44:48 CET 2018


On Thursday, 18 January 2018 00:51:18 PST Dominik Holland wrote:
> Am 01/18/2018 um 04:22 AM schrieb Thiago Macieira:
> > On Wednesday, 17 January 2018 13:25:53 PST Thiago Macieira wrote:
> >> Another idea is to update the network-chat example to use CBOR instead of
> >> its plaintext protocol. In this one, I could use the stream reader and
> >> writer. This example is a perfect candidate to have a CoAP version in the
> >> future too.
> > 
> > I've done this then:
> > https://codereview.qt-project.org/217078
> > https://codereview.qt-project.org/217079
> 
> Why not keep the existing example and do a network-chat-cbor example
> which is more advanced ?

I can do that if people think it would be better. I hadn't thought of it, so I 
just modified the example.

> In the example you could also explain why someone wants to use CBOR.

The difference in the state machine for receiving incomplete data should be 
enough of a reason. Plus the fact that it no longer needs to parse strings for 
numbers.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center






More information about the Development mailing list