[Development] Un-inlining members allowed?

[Richard Gustavsen]

Even if it's binary compatible, it sounds fragile. If the inlined function is e.g accessing symbols from the private class, someone might later come along and remove those symbols if they appear not to be used from anywhere, unknowingly of the fact that some apps still do through an old inlined version.


-Richard

________________________________
Fra: Development <development-bounces+richard.gustavsen=qt.io at qt-project.org> på vegne av Edward Welbourne <edward.welbourne at qt.io>
Sendt: mandag 22. oktober 2018 11.52.52
Til: Christian Ehrlicher
Kopi: development at qt-project.org; Allan at qt-project.org; Thiago Macieira
Emne: Re: [Development] Un-inlining members allowed?

On Sonntag, 21. Oktober 2018 20:07:38 CEST Christian Ehrlicher wrote:
>>> one more question - is it ok to un-inline a function? For example I
>>> want to move QListWidgetItem::isSelected() to the cpp file so I can
>>> properly mark QListWidget::isItemSelected() as deprecated but I'm
>>> unsure if this is allowed.

Please be sure to summarise the change in a
[ChangeLog][Potentially Source-Incompatible Changes]
in your commit message; see [QUIP 6]

* [QUIP 6] https://quips-qt-io.herokuapp.com/quip-0006.html

Thiago Macieira (21 October 2018 22:12) replied:
>> De-inlining is binary and source compatible, so long as you accept
>> that the old code that did inline the function continues to do what it
>> used o do.

and (independently)
Allan Sandfeld Jensen (22 October 2018 09:55) replied:
> That should work, though it seems unnecessary. In any case you will
> need to disable the warnings around the code using the deprecated API.

This appears to be an instance of [QUIP 6]'s Examples section saying:

  Issues not listed here should be discussed on the mailing-list and
  then added here.

Unless someone else (e.g. Allan or Thiago) beats me to it (I'm busy with
a 3rd-party review ...), I guess I'll try to summarise the above as
another example; apparently this is in Category A.  If someone else gets
there first, please add me as a reviewer, so I know when to update the
published version.  (hmm ... I think an update may be in order anyway.)

        Eddy.
_______________________________________________
Development mailing list
Development at qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20181023/f3b8a5cb/attachment.html>