[Development] Maintainers, your action needed: Qt 5.12.2 changes files

[Kai Koehne]

Somewhat related: I suggest to stop listening all changes in the commit message template. See e.g.

https://codereview.qt-project.org/#/c/253950/

This makes the commit message unnecessarily long, and also means that, if you grep though git log history for a specific change, you hit the changelog commit too.

I guess the idea was to give anyone working on the change log an idea what commit might be worth documenting. Anyhow, it seems not every reviewer removes the list before submitting, and frankly speaking it should be easy enough for everyone to run e.g. 'git log v5.12.1..5.12.2' themselves.

Kai

> -----Original Message-----
> From: Development <development-bounces at qt-project.org> On Behalf Of
> Cristián Maureira-Fredes
> Sent: Thursday, February 21, 2019 12:47 PM
> To: Mitch Curtis <mitch.curtis at qt.io>; Jani Heikkinen <jani.heikkinen at qt.io>;
> development at qt-project.org
> Subject: Re: [Development] Maintainers, your action needed: Qt 5.12.2 changes
> files
> 
> Hello,
> 
> so, we agree the Go one (qtqa) is the recommended one?
> 
> Time ago, I was directed to this one:
> http://code.qt.io/cgit/qtsdk/qtsdk.git/tree/packaging-
> tools/create_changelog.pl
> and ended up suggesting this one as a replacement for the Qt for Python
> project: https://codereview.qt-project.org/#/c/252162/
> 
> I understand it is better to focus on one script and improve it so that's why I
> would like to know which is the preferred option.
> 
> Cheers
> 
> ________________________________________
> From: Development <development-bounces at qt-project.org> on behalf of
> Mitch Curtis <mitch.curtis at qt.io>
> Sent: 21 February 2019 11:46
> To: Jani Heikkinen; development at qt-project.org
> Subject: Re: [Development] Maintainers, your action needed: Qt 5.12.2 changes
> files
> 
> > -----Original Message-----
> > From: Jani Heikkinen
> > Sent: Thursday, 21 February 2019 11:06 AM
> > To: Mitch Curtis <mitch.curtis at qt.io>; development at qt-project.org
> > Subject: RE: [Development] Maintainers, your action needed: Qt 5.12.2
> > changes files
> >
> > > -----Original Message-----
> > > From: Mitch Curtis <mitch.curtis at qt.io>
> > > Sent: torstai 21. helmikuuta 2019 11.21
> > > To: Mitch Curtis <mitch.curtis at qt.io>; Jani Heikkinen
> > > <jani.heikkinen at qt.io>; development at qt-project.org
> > > Subject: RE: [Development] Maintainers, your action needed: Qt
> > > 5.12.2 changes files
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Development <development-bounces at qt-project.org> On Behalf
> > > Of
> > > > Mitch Curtis
> > > > Sent: Thursday, 21 February 2019 9:33 AM
> > > > To: Jani Heikkinen <jani.heikkinen at qt.io>;
> > > > development at qt-project.org
> > > > Subject: Re: [Development] Maintainers, your action needed: Qt
> > > > 5.12.2 changes files
> > > >
> > > > > -----Original Message-----
> > > > > From: Development <development-bounces at qt-project.org> On
> > Behalf
> > > > Of
> > > > > Jani Heikkinen
> > > > > Sent: Thursday, 21 February 2019 9:19 AM
> > > > > To: development at qt-project.org
> > > > > Subject: [Development] Maintainers, your action needed: Qt
> > > > > 5.12.2 changes files
> > > > >
> > > > > Hi,
> > > > > Initial ones here: https://codereview.qt-
> > > > > project.org/#/q/message:%22Add+changes+file+for+Qt+5.12.2%22,n,z
> > > > >
> > > > > Please take it over, do needed modifications and get '+2' during
> > > > > this
> > > week.
> > > >
> > > > Do we have a script that generates the change logs? I see that
> > > > qtbase has entries for bug fixes with the task number:
> > > >
> > > > http://code.qt.io/cgit/qt/qtbase.git/tree/dist/changes-5.12.1/?h=v5.
> > > > 12
> > > > .1
> > > >
> > > > I'd like to get the same for the modules that I maintain. I'm
> > > > guessing that one was done manually, but I'd like to try to
> > > > automate it (even if it still requires some manual editing afterwards).
> > > >
> > > > I checked qtrepotools.git but didn't find anything. Simon created
> > > > one, but says that it's not the same one in use by the release team:
> > > >
> > > > http://code.qt.io/cgit/qt/qtqa.git/tree/src/createchangelog
> > >
> > > Replying to myself to say that this tool works really well, and is
> > > very easy to use (especially with
> > > https://codereview.qt-project.org/#/c/253973/). Can the initial
> > > change logs
> > be created with it?
> >
> > We will test this and use it in coming releases if it works better
> > that current one
> 
> For what it's worth, the only negative difference I saw was that it
> (createchangelog) generates this:
> 
> Qt 5.12.2 is a bug-fix release. It maintains both forward and backward
> compatibility (source and binary) with Qt 5.12.1.
> 
> whereas the current one generates this:
> 
> Qt 5.12.2 is a bug-fix release. It maintains both forward and backward
> compatibility (source and binary) with Qt 5.12.0 through 5.12.1.
> 
> Doesn't seem that important though?
> 
> > br,
> > Jani
> >
> > >
> > > > > br,
> > > > > Jani Heikkinen
> > > > > Release Manager
> > > > > _______________________________________________
> > > > > Development mailing list
> > > > > Development at qt-project.org
> > > > > https://lists.qt-project.org/listinfo/development
> > > > _______________________________________________
> > > > Development mailing list
> > > > Development at qt-project.org
> > > > https://lists.qt-project.org/listinfo/development
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> https://lists.qt-project.org/listinfo/development
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> https://lists.qt-project.org/listinfo/development