[Development] Oslo, we have a problem</apollo 13> [char8_t]

Allan Sandfeld Jensen kde at carewolf.com
Mon Jul 8 09:37:24 CEST 2019


On Samstag, 6. Juli 2019 16:53:13 CEST Mutz, Marc via Development wrote:
> On 2019-07-06 16:38, Konstantin Tokarev wrote:
> > 06.07.2019, 17:20, "Mutz, Marc via Development"
> > 
> > <development at qt-project.org>:
> >> On 2019-07-06 14:50, Fabian Kosmale wrote:
> >> [...]
> >> 
> >>>   See https://godbolt.org/z/e6OinY for how this would look for a
> >>>  trivial function.
> >> 
> >> [...]
> >> 
> >> Now also handle test(NULL) and extend to binary:
> >> 
> >>     test2([0, NULL, nullptr, "", u8""], [0, NULL, nullptr, "", u8""])
> >> 
> >> This doesn't scale...
> > 
> > It can be argued that use of NULL in C++ code is more relict thing and
> > should not be
> > supported. It's also much easier to migrate code base from NULL to
> > nullptr - simple text
> > replacement is enough.
> 
> 0 -> nullptr is just as simple: clang-tidy has a fixit for that.

Won't work on Qt code. At least no nicely. When I tried cleaning up QtCore I 
found we do something ugly with QFlags where passing a 0 somehow goes over  
pointer. The fix for
QFlags<Foo> a(0)
is 
QFlags<Foo> a = {}

or we need to update our hack to not trigger the 0 as pointer constant 
warning.

'Allan





More information about the Development mailing list