[Development] Deprecate the Keccak hashes in QCryptographicHash?

[Giuseppe D'Angelo]

On 18/06/2019 18:01, Thiago Macieira wrote:
> We have them because we made a mistake when we added SHA3 support. We've kept
> them for compatibility, for people who had hashes to compare to and had
> accidentally used Keccak.
> 
> They're the only ones we couldn't fall back to Linux's AF_ALG or OpenSSL's
> support, which often contain more optimised code that ours.

Weren't there some reports about users that have accidentally generated 
Keccak hashes with Qt 5.x, and thus required the algorithms to be left 
in in order to have backwards compatibility? (Sure thing, those hashes 
should have been regenerated by now...).

My 2 c,
-- 
Giuseppe D'Angelo | giuseppe.dangelo at kdab.com | Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, http://www.kdab.com
KDAB - The Qt, C++ and OpenGL Experts

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4329 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.qt-project.org/pipermail/development/attachments/20190618/0bdfa0f3/attachment.bin>