[Development] Gerrit Bot closing reopened Bugs?

Robert Loehning Robert.Loehning at qt.io
Tue Mar 26 11:41:12 CET 2019

Am 26.03.2019 um 09:48 schrieb Frederik Gladhorn:
> On fredag 15. mars 2019 14:05:39 CET Robert Loehning wrote:
>> Hi *,
>> imagine the following situation:
>> 1. Bug in 5.13 is reported
>> 2. Patch with "Fixes: " is merged to 5.13 branch
>> 3. Gerrit Bot closes the report with "Fix Version 5.13".
>> 4. Reporter tests 5.13 branch, fix failed, reopens report
>> 5. Patch is merged to dev branch
>> 6. Gerrit Bot finds the patch in dev branch
>> What will the Gerrit do now? Will it close the reopened bug report
>> again? I'm asking because this seems to have happened in
>> https://bugreports.qt.io/browse/QTCREATORBUG-21994
>> (with Creator's branches 4.9 and master)
>> The Gerrit Bot should not close bug reports which were reopened unless
>> there is another patch. If this really happened as I suspect here, could
>> someone please fix it?
> Indeed, I agree. This was something I didn't consider when writing the bot.
> I want to fix this issue, but I'm not sure when I'll get around to fixing it.
> So far it was developed internally, but I just created a request on Gerrit to
> let you review the code:
> https://codereview.qt-project.org/#/c/257050/
> I think it should be very doable to extend the bot to check if the last
> transition was a re-open, in which case it could just drop a message and not
> close the bug again.
> Cheers,
> Frederik

Hi Frederik,

neither do I know when I'll get around to fixing it, sorry. If nobody 
else fixes it soon, my proposal would be to shut off this bot until it 
works correctly.


More information about the Development mailing list