[Development] unique_ptr and Qt, Take 2

Lars Knoll lars.knoll at qt.io
Mon May 6 09:41:05 CEST 2019

> On 6 May 2019, at 09:30, Christian Kandeler <christian.kandeler at qt.io> wrote:
> On Sat, 04 May 2019 09:06:39 +0200
> Allan Sandfeld Jensen <kde at carewolf.com> wrote:
>> On Samstag, 4. Mai 2019 00:43:10 CEST Thiago Macieira wrote:
>>> On Friday, 3 May 2019 13:00:52 PDT Иван Комиссаров wrote:
>>>> Which should be considered bad practice and banned on an API level
>>> No way.
>>> Are you going to forbid creation of QFile on the stack?
>> Perhaps QFile shouldn't be the same kind of base object type as QWidgets? Or 
>> not use the same smart pointer.
>> Though even making QWidgets not allowed on the stack, while sensible, would 
>> break a many of our tests, where we "abuse" that it is technically possible in 
>> simple cases.
> Doesn't almost every project create its main widget on the stack? 

Not sure whether it’s most projects, but there certainly are users doing it. And we’ve been using the pattern in our examples in some cases as well. But I can relate to Allan that creating widgets on the stack is bad style (as it conflicts with the way we memory manage them), and if I’d have a choice today, I would probably prefer to enforce them to be created on the heap by some means.


More information about the Development mailing list