[Development] GitHub Pull requests

[Jean-Michaël Celerier]

> otherwise we may end up accepting contributions from Twitter :)

what is the problem if they improve the code  ?

On Tue, Mar 10, 2020 at 3:49 PM Konstantin Tokarev <annulen at yandex.ru>
wrote:

>
>
> 10.03.2020, 17:42, "Cristian Adam" <cristian.adam at qt.io>:
> > Hi,
> >
> > With the “GitHub issues” E-Mail thread we made sure the Issues are gone
> >
> > from the projects.
> >
> > What about Pull requests?
> >
> > For example qtbase has 7 pull requests.  Usually people point out that
> >
> > the Qt project uses a different collaboration method:
> >
> > https://wiki.qt.io/Qt_Contribution_Guidelines
> >
> > What stops us from accepting the contributions via GitHub?
> >
> > Is it:
> >
> > * The CLA
> > * Qt Account
> >
> > For the CLA one can simply add an instance of:
> >
> > https://github.com/cla-assistant/cla-assistant
> >
> > And it’s only one click away.
> >
> > When I contributed to vcpkg, the process of signing the Microsoft
> >
> > CLA was like that, one click.
> >
> > Regarding Qt Account, maybe one can use the GitHub account to
> >
> > create a Qt Account via openid.
> >
> > With GitHub actions (or Azure Pipelines, like vcpkg) we can also validate
> >
> > the pull requests.
> >
> > We should encourage developers to contribute to Qt, not having to learn
> >
> > how to use gerrit, and using a workflow that they are familiar with,
> should
> >
> > be a plus.
>
> I think, lowering barrier of entry at expense of reviewers' convenience
> should
> have its limits, otherwise we may end up accepting contributions from
> Twitter :)
>
> --
> Regards,
> Konstantin
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> https://lists.qt-project.org/listinfo/development
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20200310/e767b01b/attachment.html>