[Development] QVariant comparison in Qt6 (URGENT)

Giuseppe D'Angelo giuseppe.dangelo at kdab.com
Mon Nov 23 16:24:27 CET 2020


On 23/11/2020 11:29, Lars Knoll wrote:
>> I've quickly implemented 3) and pushed it here. It's only missing docs.
>>
>> https://codereview.qt-project.org/c/qt/qtbase/+/322900
>>
>> (includes the rationale of why optional is the wrong datatype)
>>
> I like this approach.

Thanks, patch is ready for review now.


>> Still in time to target 6.0.0?
> I guess it’s now or never ;-)
> 
> Have you checked that it doesn’t cause issues in other modules? The API is new, so I doubt it’s used widely.

Still re-building the world, but I don't think compare() was used 
anywhere...

Thanks,
-- 
Giuseppe D'Angelo | giuseppe.dangelo at kdab.com | Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, http://www.kdab.com
KDAB - The Qt, C++ and OpenGL Experts

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4329 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.qt-project.org/pipermail/development/attachments/20201123/c67c2e6e/attachment.bin>


More information about the Development mailing list