[Development] Using Git notes to reflect actual cherry-picks

Thiago Macieira thiago.macieira at intel.com
Sat Mar 5 20:07:17 CET 2022


On Monday, 21 February 2022 17:21:30 PST Thiago Macieira wrote:
> On Saturday, 12 February 2022 07:15:36 PST Tor Arne Vestbø wrote:
> > Very cool! As ossi suggests, this could potentially be handled by Gerrit,
> > similar to this:
> > 
> > https://gerrit.googlesource.com/plugins/reviewnotes/%2B/master/src/main/re
> > so
> > urces/Documentation/refs-notes-review.md<https://gerrit.googlesource.com/
> > plu
> > gins/reviewnotes/+/master/src/main/resources/Documentation/refs-notes-rev
> > iew .md>
> > 
> > If we enable something like this we should namespace the notes, e.g.
> > refs/notes/cherry-picks so that fetching and showing them in git log
> > output
> > is optional.
> 
> I haven't heard anyone volunteer to make this work.
> 
> All this requires is that someone run a cron job every week and have rights
> to push to the refs/notes/* hierarchy.

Anyone?

The script worked for the recently-published 5.15.3 too:

$ git -P log -1 dec429e0778493bc4e85d6b18202804d0bbbe5f1
commit dec429e0778493bc4e85d6b18202804d0bbbe5f1
Author: Andreas Buhr <andreas.buhr at qt.io>
Date:   Wed Feb 17 20:15:04 2021 +0100

    Fix handling of virtual/native pixels in QAndroidPlatformWindow
    
    f92e1953699b2529cc6ea2fd399fe4f2b887e83c made sure a new
    QAndroidPlatformWindow always has a geometry. However, it did not
    take into account HiDPI handling. This patch fixes it and introduces
    proper HiDPI handling.
    
    Pick-to: 5.15 6.0 6.1
    Fixes: QTBUG-91161
    Change-Id: Iddf31b7abfd0a1bada3b051ed4de3bf6c2897d8e
    Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo at qt.io>

Notes:
    Cherry-picks:
        5.15.3: 8a5a172987c659369831b87585a08003caef0127
        6.0: 7833eae30499b29d810c2f105db1e56f905008c2
        6.1: 7898f6a6aa1fec3638d283ac271f01770453fa12


-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel DPG Cloud Engineering





More information about the Development mailing list