[Development] Warnign when building qtbase: -Walloc-size-larger-than

Thiago Macieira thiago.macieira at intel.com
Tue Feb 7 01:11:17 CET 2023


On Monday, 6 February 2023 15:15:36 PST Lisandro Damián Nicanor Pérez Meyer 
wrote:
> > Actually, maxNumBuckets is wrong, allowing bucketsForCapacity to overflow.
> > But in practice this will only affect you after the QHash has grown to
> > more than half the virtual memory size (which can only happen on 32-bit
> > systems today).
> > 
> > Working on a fix right now. Will push soon.
> 
> Thanks!

https://codereview.qt-project.org/c/qt/qtbase/+/458585

Aside from the load factor change, this is a no-op: it doesn't fix anything 
because no ill effects could happen anyway. But it does simplify calculations, 
so it's a win.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Cloud Software Architect - Intel DCAI Cloud Engineering
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5167 bytes
Desc: not available
URL: <http://lists.qt-project.org/pipermail/development/attachments/20230206/136754f6/attachment.bin>


More information about the Development mailing list