[Development] Adding a .gitreview to all repos

[Paul Wicking]

I decided to make it easy for y'all: vote with your feet :)

https://codereview.qt-project.org/q/topic:"add-gitreview-config"<https://codereview.qt-project.org/q/topic:%22add-gitreview-config%22>

//! Paul

On 13 Feb 2025, at 12:48, Volker Hilsheimer via Development <development at qt-project.org> wrote:

On 12 Feb 2025, at 22:22, Sérgio Martins <iamsergio at gmail.com<mailto:iamsergio at gmail.com>> wrote:

On Wed, Feb 12, 2025 at 10:44 AM Cristian Le via Development
<development at qt-project.org> wrote:

I want to gather some feedback about adding a .gitreview file for all repos. The file would look like

```
[gerrit]
host=codereview.qt-project.org
project=qt/qtbase
defaultbranch=dev
```

This would help with out-of-the-box support for some IDEs, e.g. on Jetbrains ones it read this file to determine the default for where to submit the gerrit reviews.

If you have git-review cli you also have more simple interface to submit and fetch changes, e.g.
```
(Cherry-pick gerrit change)
$ git review -x <Change-ID>
(Submit a change)
$ git review -s 6.9
```

For new external contributors this also signals straight away that the projects are managed by gerrit and where to submit the changes.

For more reference about the .gitreview check the upstream documentation [1]. There is also a Jira bug I've opened about adding this file [2].

[1]: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.opendev.org%2Fopendev%2Fgit-review%2Flatest%2Finstallation.html%23gitreview-file-format&data=05%7C02%7Cpaul.wicking%40qt.io%7C899ffc3d236148ab324108dd4c24deae%7C20d0b167794d448a9d01aaeccc1124ac%7C0%7C0%7C638750443408328579%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=nXnqaEY1%2FLfMPXjtOKYCJG90as1nzQmIAjbKETo35EE%3D&reserved=0<https://docs.opendev.org/opendev/git-review/latest/installation.html#gitreview-file-format>
[2]: https://bugreports.qt.io/browse/QTBUG-132604

Yes, .gitreview is pretty standard for gerrit and there's no downside
for whoever isn't using it.



Regards,
Sergio Martins

Any change that makes our repos easier to work with using generally available tooling is welcome.

“git-review” is not part of the standard git toolset, but it’s available from at least some package managers. Our (or anyone's, as far as I can tell) git-gpush isn't.

So, adding those files is fine by me; ideally, those additions come with some information on the wiki on how to then set up a workable clone of the Qt repositories.

Volker

--
Development mailing list
Development at qt-project.org<mailto:Development at qt-project.org>
https://lists.qt-project.org/listinfo/development

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20250217/bc181818/attachment-0001.htm>