[Interest] Makefile target for mocinclude.tmp using inconsistent slashes

[James Cotton]

So this patch worked for me

diff -u ./tools/Qt5.0.1/5.0.1/clang_64/mkspecs/features/moc.prf
./tools/Qt5.0.1/5.0.1/clang_64/mkspecs/features/moc2.prf
--- ./tools/Qt5.0.1/5.0.1/clang_64/mkspecs/features/moc.prf 2013-02-26
19:55:19.000000000 -0600
+++ ./tools/Qt5.0.1/5.0.1/clang_64/mkspecs/features/moc2.prf 2013-04-23
10:15:31.000000000 -0500
@@ -25,8 +25,8 @@
     RET =
     for(incfile, $$list($$INCLUDEPATH)) {
         INCFILELIST = -I$$incfile
-        isEmpty(RET): RET += @echo $$INCFILELIST> $$WIN_INCLUDETEMP $$EOC
-        else:         RET += @echo $$INCFILELIST>> $$WIN_INCLUDETEMP $$EOC
+        isEmpty(RET): RET += @echo $$clean_path($$INCFILELIST)>
$$WIN_INCLUDETEMP $$EOC
+        else:         RET += @echo $$clean_path($$INCFILELIST)>>
$$WIN_INCLUDETEMP $$EOC
     }
     !isEmpty(INCFILELIST):RET += @echo $$INCFILELIST>> $$WIN_INCLUDETEMP
$$EOC

if it looks like something that wouldn't break the standard workflow then I
can look into the submission process and send it.  Does it seem like a
reasonable solution?



On Tue, Apr 23, 2013 at 1:52 AM, Koehne Kai <Kai.Koehne at digia.com> wrote:

>
>
> > -----Original Message-----
> > From: interest-bounces+kai.koehne=digia.com at qt-project.org
> > [mailto:interest-bounces+kai.koehne=digia.com at qt-project.org] On Behalf
> > Of James Cotton
> > Sent: Monday, April 22, 2013 8:42 PM
> > To: interest at qt-project.org
> > Subject: [Interest] Makefile target for mocinclude.tmp using inconsistent
> > slashes
> >
> > I'm having an issue on windows where the mocinclude.tmp makefile
> > command lists the Qt includes like this
> >
> >         @echo -IC:/TauLabs/ground/gcs/src/plugins/uavobjects>>
> > debug/mocinclude.tmp
> >         @echo -IC:/TauLabs/ground/gcs/src/libs/libqxt/src/core>>
> > debug/mocinclude.tmp
> >         @echo -IC:\TauLabs\tools\Qt5.0.2\5.0.2\mingw47_32\include>>
> > debug/mocinclude.tmp
> >         @echo -IC:\TauLabs\tools\Qt5.0.2\5.0.2\mingw47_32\include/QtSvg>>
> > debug/mocinclude.tmp
> >
> > the later two are not mangled by echo to create this in mocinclude.tmp
> >
> > -IC:/TauLabs/ground/gcs/src/libs/libqxt/src/core
> > -IC:/TauLabs/ground/gcs/src/libs/libqxt/src/core/logengines
> > -IC: TauLabstoolsQt5.0.25.0.2mingw47_32include
> > -IC: TauLabstoolsQt5.0.25.0.2mingw47_32include/QtSvg
> >
> > which obviously dosen't work.  This is using makespec win32-g++ I've
> > checked that the INCLUDEPATH passed to moc.prf looks like the former.
> > Should moc.prf be taking care of converting the paths to use / or
> escaping
> > the slashes?  Alternatively when using msys should the QT_INCLUDE_PATH
> > be forced to use / instead?
>
> I'm shooting in the dark here, but consider that
>  - building from cmd.exe not inside msys/sh) is the only really tested
> setup
>    (though patches are of course welcome to also support msys/sh)
>  - if you build from cmd.exe, make sure you don't have sh.exe in your PATH
>
> Regards
>
> Kai
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/interest/attachments/20130423/f3897cfe/attachment.html>