[Interest] Qt3 repository

Diego Iastrubni diegoiast at gmail.com
Thu Aug 22 13:06:25 CEST 2013


Just a few random commits I see:

- http://git.trinitydesktop.org/cgit/qt3/commit/?id=7c0bc39229bbba839dea93fe12b0d2cdbe21eec0

The message log claims that deleting "NULL" will crash an app. This is
not true, as in C++ you can safely delete a null pointer.

whrp74 at srv690 src $ make test1
g++     test1.cc   -o test1
whrp74 at srv690 src $ ./test1
whrp74 at srv690 src $ cat test1.cc
int main()
{
        int *i = 0;
        delete i;
        return 0;
}
whrp74 at srv690 src $ gcc --version
gcc (Ubuntu 4.4.3-4ubuntu5.1) 4.4.3
Copyright (C) 2009 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

The bug they fix is still there.

- http://git.trinitydesktop.org/cgit/qt3/commit/?id=679d4f0bcdd20ef467ee02b366bf024779950fc2

OOPS. This a very good fix. Lets hope we don't have it in Qt5.


- http://git.trinitydesktop.org/cgit/qt3/commit/?id=16f24a61f80fef5f29c81182a3bcf3906bdee7a7

In this bug they modify the embedded sqlite3. This is bad.
I am not sure why they do this change:
- qWarning( QString( "QODBCDriver::open: Unknown option value '%1'"
).arg( *it ) );
+ qWarning( "QODBCDriver::open: Unknown option value '%s'", (*it).latin1() );

- http://git.trinitydesktop.org/cgit/qt3/commit/?id=58451e41d9ecfb405f5dd2718444ac78e8d51c8b

Be warned:
+Qt 3.5 is a new feature release. It is not backwards compatible with any
+prior Qt3 version due to changes in the QStyle API.


 - http://git.trinitydesktop.org/cgit/qt3/commit/?id=04fcdc080321c9531c5b61e6f216d3967f2d39ef
sed -i 's/kwin/twin/g'? This commit seems very ... ... ... . ?

This is what I see from very limited view. Note, I have no idea what I
am talking about, and I might be wrong. Its very easy to criticize
someone when you are an outsider. but...

It seems that this works for them as an OSS, but for a proprietary
app.. be careful, you cannot iterate that often and you have only one
delivery.


On Thu, Aug 22, 2013 at 12:24 AM, Thiago Macieira
<thiago.macieira at intel.com> wrote:
> On quarta-feira, 21 de agosto de 2013 20:06:50, Guido Seifert wrote:
>> Is there a changlog, which explains, what the patches do? This is not a
>> direct question to you, Thiago.
>
> They appear to have written changelogs for their 3.3.8c and d releases. The
> "c" release's changelog clearly violates Qt patch release policies, by adding
> symbols that weren't there before.
>
> As for the rest, I believe their changelog is the Git log.
>
> --
> Thiago Macieira - thiago.macieira (AT) intel.com
>   Software Architect - Intel Open Source Technology Center
>
> _______________________________________________
> Interest mailing list
> Interest at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/interest
>



More information about the Interest mailing list