[Interest] Gerrit reviewers

Thiago Macieira thiago.macieira at intel.com
Thu Jun 6 00:00:21 CEST 2013


On quarta-feira, 5 de junho de 2013 23.53.30, Samuel Gaist wrote:
> On 5 juin 2013, at 23:50, Thiago Macieira wrote:
> > On quarta-feira, 5 de junho de 2013 23.33.32, Samuel Gaist wrote:
> >> Where should I put the explanation ? In this case, this file is not part
> >> of
> >> Qt 5 at all.
> > 
> > In the commit message. Just write in it that "this change does not apply
> > to Qt 5 because so and so".
> 
> All right, but I've already pushed the changes to gerrit...
> 
> Do I have another possibility to add this information ?

Sure. Do a git commit --amend, edit your commit message, and re-push.

As long as the Change-Id line is the same, you'll simply update the Gerrit 
change.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/interest/attachments/20130605/aeea9303/attachment.sig>


More information about the Interest mailing list