[Interest] Need argumentative help..... giving qobject copy/assignment constructor and put it in qlist/qmap

[Tony Rietwyk]

Hi Guido, 

 

Did they patch QObject itself, or just add these routines to a descendent - I'll assume the latter.  The added routines can't be calling the QObject ancestor routines, since that wouldn't compile.  So what are the routines doing?  Just copying over their own member vars?  We'll need to see some code to decide how bad it is. 

 

Regards, 

 

Tony

 

 

From: interest-bounces+tony=rightsoft.com.au at qt-project.org [mailto:interest-bounces+tony=rightsoft.com.au at qt-project.org] On Behalf Of Guido Seifert
Sent: Monday, 20 July 2015 10:51 PM
To: interest at qt-project.org
Subject: [Interest] Need argumentative help..... giving qobject copy/assignment constructor and put it in qlist/qmap

 

Hi, just seen this in project's code. Worse, I have been told to do it exactly this way in another code part. I must say I am less than thrilled. On first glance this code seems to work. There is not much copying around. The objects sit happily in their containers. But it smells. So what is the worst what can be expected? Something not obvious? On different compilers? I need some convincing reasons, which cannot just waved away..... or confirmation that eveything is fine and I can stop worrying.... but this also must be convincing. Perhaps even more ;-)
-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/interest/attachments/20150721/44f572ca/attachment.html>