[Interest] Need argumentative help..... giving qobject copy/assignment constructor and put it in qlist/qmap

Matthew Woehlke mwoehlke.floss at gmail.com
Wed Jul 22 23:14:43 CEST 2015


On 2015-07-22 16:52, Thiago Macieira wrote:
> please take a look at the list of MSVC warnings we turn off completely:
> 
> http://code.woboq.org/qt5/qtbase/src/corelib/global/qglobal.h.html#897
> 
> Of those, C4275, C4514, C4800, C4097, C4786 and C4710 are stupid. I can't see 
> anyone who wants to know those warnings.
> 
> I'll concede we may have gone too far on C4244 and C4355.

What about 4706? At least gcc (and probably clang) also warns about
this, but with 'suggest ()'s around assignment used as truth value'.
Does MSVC not have the same "escape hatch"? (At least this one probably
should not be propagated to users.)

If 4244 is anything like -Wconversion, it's something of a crap-shoot...
it's *possible* to write code that doesn't trip it, but tends to result
in a lot of explicit casts where an intentional narrowing conversion occurs.

I'd be a little suspicious of any 4355 popping up :-).

At least all three of the above are probably better restored to the
user's state after Qt code.

-- 
Matthew




More information about the Interest mailing list