[Interest] invalidated copies of QString in QCommonStyle::cachedOption

Thiago Macieira thiago.macieira at intel.com
Wed Jan 20 22:28:26 CET 2016


On Wednesday 20 January 2016 12:34:33 Mojmír Svoboda wrote:
> On 20.1.2016 11:26, Igor Mironchik wrote:
> > Just looked a little at your code. And that what I can say: your code
> > has nothing with QStringLiteral.
> 
> QStringDataTable uses the same technique as QStringLiteral.

There's no such class. Don't name your classes with Q + capital letter, 
please.

> > And I don't understand why you need such a "crazy" :) code? May be would
> > be much more better and effective to implement custom model and just
> > store in the model normal QStrings?
> 
> Normally these strings are read-only so there is no reason to allocate
> them on a heap. And there are lots of them (may exceed order 10^6)
> Then I met the article I mentioned earlier so I went for it, because it
> seems like a neat feature... what could possibly go wrong? :)

Just don't unmap your file. Ever.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center




More information about the Interest mailing list