[Interest] Documentation missing for QAbstractListModel::columnCount/hasChildren ?

[Elvis Stansvik]

2016-06-02 9:35 GMT+02:00 Elvis Stansvik <elvstone at gmail.com>:
> Hi all,
>
> There's currently this [1]:
>
> /*!
>     \internal
>     Returns the number of columns in the list with the given \a parent.
>     \sa rowCount()
> */
>
> int QAbstractListModel::columnCount(const QModelIndex &parent) const
> {
>     return parent.isValid() ? 0 : 1;
> }
>
> bool QAbstractListModel::hasChildren(const QModelIndex &parent) const
> {
>     return parent.isValid() ? false : (rowCount() > 0);
> }
>
> which means rowCount/columnCount don't show up in the docs for
> QAbstractListModel under "Reimplemented Public Functions".
>
> Shouldn't both of these be given /*! \reimp */ comments? Or should I
> not rely on QAbstractListModel taking care of these for me? (..and
> their implementation there is just an undocumented precaution against
> sloppy model authors?).

Nevermind, I completely missed that these methods were made private in
QAbstractListModel/QAbstractTableModel.

Elvis

>
> Elvis
>
> [1] https://github.com/qtproject/qtbase/blob/dev/src/corelib/itemmodels/qabstractitemmodel.cpp#L3560-L3576