[Interest] QMAKE_DEFAULT_INCDIRS = "/opt/local/include /usr/include" and building QtWebengine
René J. V. Bertin
rjvbertin at gmail.com
Fri Jun 24 12:59:13 CEST 2016
René J. V. Bertin wrote:
> I checked, the DEFAULT_INCDIRS and DEFAULT_LIBDIRS variables in
> qtbase/configure do not have quotes.
Some more on this: I did patch qtbase/configure to prune a number of undesirable
paths from those 2 variables. Without that patch I do not get the quotes. I
haven't been able to understand why the behaviour is different in those 2 cases,
but it may be related to the fact that my patch already converts the newlines to
a series of spaces.
I found a fix though:
--- a/qtbase/configure
+++ b/qtbase/configure
@@ -122,7 +122,7 @@ shellQuoteLines()
{
# The call of the outer echo makes the shell word-split the output of
# the nested pipe, thus effectively converting newlines to spaces.
- echo `echo "$1" | sed 's,^[^ ]* .*$,"&",'`
+ echo `echo $@ | sed 's,^[^ ]* .*$,&,'`
}
This makes it possible to call shellQuoteLines without quoting the argument
(e.g. `shellQuoteLines $DEFAULT_INCDIRS`) and doesn't introduce any quotes in
the procedure itself. In fact, I'm surprised that I wasn't getting quotes in the
stock configure; probably because the original input doesn't have runs of 2 or
more spaces.
Hope this helps :)
R.
More information about the Interest
mailing list