[Localization] Change in qt/qttranslations[5.4]: Add Greek(el) translation for qt and qtbase

Dimitrios Glentadakis dglent at free.fr
Sat Dec 27 11:14:02 CET 2014


Την Παρασκευή, 26 Δεκεμβρίου 2014 12:37:07 Μ.Μ. CEST, Sergey Belyashov 
(Code Review) γράψατε:
> Sergey Belyashov has posted comments on this change.
>
> Change subject: Add Greek(el) translation for qt and qtbase
> ......................................................................
>
>
> Patch Set 1: Code-Review-1
>
> You are forget other ts files. See qt_el.ts for list of them 
> (there is only first part of name, like qtbase_ which means 
> qtbase_el.ts).
> To commit files use 'make commit-ts' command instead of 'git 
> commit'. It removes unneccessary information (locations) from 
> translations and add all changed files.
>
> To update this change checkout it, rewrite files by new ones, 
> use git commit --amend <list of files> to commit them and then 
> use git push gerrit HEAD:refs/for/5.4 to push change.
>

Now i have this:

i have still the same chackout:
[dglent at localhost translations (Greek-translation)]$ git status
On branch Greek-translation
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   qt_el.ts

Untracked files:
  (use "git add <file>..." to include in what will be committed)

        git
        qtmultimedia_el.ts
        qtquick1_el.ts
        qtscript_el.ts
        qtxmlpatterns_el.ts

no changes added to commit (use "git add" and/or "git commit -a")


Can you please confirm me the steps below? 
1) make commit-ts
2) git commit --amend file1 file2 etc... (except the 'git' which must be 
created by accident)
3) git push gerrit HEAD:refs/for/5.4






More information about the Localization mailing list