From rudolfs.mazurs at gmail.com Mon May 5 20:32:32 2014 From: rudolfs.mazurs at gmail.com (=?UTF-8?Q?R=C5=ABdolfs?= Mazurs) Date: Mon, 05 May 2014 21:32:32 +0300 Subject: [Localization] Qt5.3 string freeze In-Reply-To: References: Message-ID: <1399314752.2672.7.camel@steps> Hi all C , 2014.04.10. 06:29 +0000, Heikkinen Jani rakstīja: > As informed last week string freeze is now in effect. Please, no > changes to translatable strings from this point, unless approved by > the documentation team. I have translated some files for QT 5.3, made account on codereview.qt-project.org and bugreports.qt-project.org (gave public key), cloned the QT5 repositories, added and commited the translations on stable branch, BUT I am not sure how exactly I should push the changes to gerrit. I tried git push ssh://rudolfs at codereview.qt-project.org:29418/qt/qtbase stable:refs/for/stable but it failed. What is the correct push command? -- Rūdolfs Mazurs From Jani.Heikkinen at digia.com Tue May 6 07:03:49 2014 From: Jani.Heikkinen at digia.com (Heikkinen Jani) Date: Tue, 6 May 2014 05:03:49 +0000 Subject: [Localization] Qt5.3 string freeze In-Reply-To: <1399314752.2672.7.camel@steps> References: <1399314752.2672.7.camel@steps> Message-ID: Hi! First of all, if you are targeting your translations to 5.3 you need to push your changes to release branch. And if you setup is OK just git push ssh://codereview.qt-project.org/qt/qtbase HEAD:refs/for/release is enough Br, Jani >>-----Original Message----- >>From: Rūdolfs Mazurs [mailto:rudolfs.mazurs at gmail.com] >>Sent: 5. toukokuuta 2014 21:33 >>To: Heikkinen Jani >>Cc: localization at qt-project.org >>Subject: Re: [Localization] Qt5.3 string freeze >> >>Hi all >> >>C , 2014.04.10. 06:29 +0000, Heikkinen Jani rakstīja: >>> As informed last week string freeze is now in effect. Please, no >>> changes to translatable strings from this point, unless approved by >>> the documentation team. >> >>I have translated some files for QT 5.3, made account on >>codereview.qt-project.org and bugreports.qt-project.org (gave public >>key), cloned the QT5 repositories, added and commited the translations >>on stable branch, BUT I am not sure how exactly I should push the >>changes to gerrit. I tried >> >>git push ssh://rudolfs at codereview.qt-project.org:29418/qt/qtbase >>stable:refs/for/stable >> >>but it failed. What is the correct push command? >> >>-- >>Rūdolfs Mazurs From oswald.buddenhagen at digia.com Tue May 6 11:02:08 2014 From: oswald.buddenhagen at digia.com (Oswald Buddenhagen) Date: Tue, 6 May 2014 11:02:08 +0200 Subject: [Localization] Qt5.3 string freeze In-Reply-To: <1399314752.2672.7.camel@steps> References: <1399314752.2672.7.camel@steps> Message-ID: <20140506090207.GA23482@troll08.it.local> hi, On Mon, May 05, 2014 at 09:32:32PM +0300, Rūdolfs Mazurs wrote: > git push ssh://rudolfs at codereview.qt-project.org:29418/qt/qtbase stable:refs/for/stable > > but it failed. What is the correct push command? > "failed" is no useful problem report. posting the complete output of the command would be in order. as jani noted, it is probably wise to rebase the change to the release branch (it's probably easiest to just check out the release branch and run 'git cherry-pick stable'). From rudolfs.mazurs at gmail.com Tue May 6 12:36:54 2014 From: rudolfs.mazurs at gmail.com (=?UTF-8?Q?R=C5=ABdolfs?= Mazurs) Date: Tue, 06 May 2014 13:36:54 +0300 Subject: [Localization] Qt5.3 string freeze In-Reply-To: References: <1399314752.2672.7.camel@steps> Message-ID: <1399372614.2774.16.camel@steps> Hi, 2014.05.06. 05:03 +0000, Heikkinen Jani wrote: > And if you setup is OK just git push > ssh://codereview.qt-project.org/qt/qtbase HEAD:refs/for/release thanks for the pointer. After putting information from several sources, the command that worked was: git push ssh://@codereview.qt-project.org:29418/qt/qttranslations HEAD:refs/for/release I think this string should be added to localization wiki [0], because contribution guidelines [1] expect intimate knowledge of qt git setup, which is expected form developer, but can be confusing for translators. 2014.05.06. 11:02 +0200, Oswald Buddenhagen wrote: >"failed" is no useful problem report. I was so sure the "git push" command was obviously wrong, that any detailed error report wouldn't add anything useful. [0] https://qt-project.org/wiki/Qt_Localization [1] https://qt-project.org/wiki/Qt-Contribution-Guidelines From oswald.buddenhagen at digia.com Tue May 6 14:05:58 2014 From: oswald.buddenhagen at digia.com (Oswald Buddenhagen) Date: Tue, 6 May 2014 14:05:58 +0200 Subject: [Localization] Qt5.3 string freeze In-Reply-To: <1399372614.2774.16.camel@steps> References: <1399314752.2672.7.camel@steps> <1399372614.2774.16.camel@steps> Message-ID: <20140506120558.GB23482@troll08.it.local> On Tue, May 06, 2014 at 01:36:54PM +0300, Rūdolfs Mazurs wrote: > 2014.05.06. 05:03 +0000, Heikkinen Jani wrote: > > And if you setup is OK just git push > > ssh://codereview.qt-project.org/qt/qtbase HEAD:refs/for/release > > 2014.05.06. 11:02 +0200, Oswald Buddenhagen wrote: > >"failed" is no useful problem report. > I was so sure the "git push" command was obviously wrong, that any > detailed error report wouldn't add anything useful. > well, it was - the repository was simply wrong. but spotting such obvious mistakes is not always as easy as it seems, and seeing the error messages often triggers helpful associations. > I think this string should be added to localization wiki [0], because > contribution guidelines [1] expect intimate knowledge of qt git setup, > which is expected form developer, but can be confusing for translators. > that would just add even more redundancy, which makes maintaining a consistent state even harder. i have a long-standing todo item to de-duplicate some of the pages ... the gerrit into recomments using the git-gpush command to avoid problems of this type.