[QBS] Qt4/Phonon not correctly supported by qtprofilesetup

[Thomas Epting]

Hi Christian,

Unfortunately I don't have a working Gerrit account yet and it also turns
out to be very difficult accessing it (or even Git) from within my
company's Intranet. Could you please push the patch on behalf of me?

Thanks,
Thomas



2014-05-08 17:11 GMT+02:00 Christian Kandeler <christian.kandeler at digia.com>
:

> Hi Thomas,
>
>  > However we figured out a problem with Qt4 projects using the "phonon"
> > submodule. The qtModuleName contained in the generated module.qbs file
> > is obviously wrong ("onon"), and the library name results in "Qtonon4",
> > which is also not correct.
> >
> > I had a look at the source code and found out that line 305 of
> > qtprofilesetup.cpp seems to be responsible for the wrong module name,
> > since the first two characters of the module name are always removed
> > (which shortens "phonon" to "onon"). Fixing this along with additional
> > code for adapting the library name would be a possible solution. However
> > I think it would be better to use a specific phonon.qbs module. So I've
> > created a patch which fixes the problem for me (see attachment). Maybe
> > you can include this on the 1.2 branch?
>
> thanks for the patch, but we can only accept submissions via gerrit. Can
> you please push it there?
>
>
> Christian
> _______________________________________________
> QBS mailing list
> QBS at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/qbs
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/qbs/attachments/20140508/65c42563/attachment.html>