[Qt-creator] Qt Creator 1.2.0 Cmake build patch

[Helio Chissini de Castro]

Andre Poenitz escreveu:
> On Fri, Jul 03, 2009 at 04:58:10PM -0300, Itamar Reis Peixoto wrote:
>> you're trying to commit this patch since long time.
>>
>> why it's not accepted ?
> 
> For one, the patch contains uic and moc generated files.  That's clearly
> not acceptable.

Was a mistake, not intended to be there, i even need correct in my 
building patch.

> 
> Same goes for needless '#include "*.moc"'. That's nothing to fix within
> Creator but something to fix within cmake.

automoc4, not cmake. I will find the issue there.

> 
> If these were fixed and we agreed that supporting two build systems
> makes sense (which I doubt but wouldn't veto) I'd still wanted to have
> the 'secondary' system outside the main src/* tree. Maybe a parallel
> build/* directory or such.
> 
> Apart from these show stoppers there are minor issues. There's e.g.
> 
> +    PATTERN "share.pr0" EXCLUDE
> 
> I am not sure what this is good for.

is a typo that i fixed already here. Basically i install everything 
under share directory except some files, share.pro is one of then.

-- 
Helio Chissini de Castro
KDE South America and Brazil Primary Contact
KDE Developer since 2002