[Qt-creator] segmentation fault

[Eike Ziller]

On Mar 26, 2010, at 9:57 AM, ext Mark Brand wrote:

> 
>  Hi,
> 
> Lately the head of qt-creator master branch has been crashing with a 
> segmentation fault when I open a form. This patch keeps it from 
> crashing, but I don't know if this is the right way to fix it.

Thanks for the report, should be fixed with
4f4bbe98289f20b760bffb6f2d63f6ec9b93e093 and
0befb98c203cac04e85d7cb3b3bc52620b1cbad8

Br, Eike

> For what it's worth:
> 
> 
> diff --git a/src/plugins/coreplugin/editortoolbar.cpp 
> b/src/plugins/coreplugin/editortoolbar.cpp
> index 6fa3737..b32d768 100644
> --- a/src/plugins/coreplugin/editortoolbar.cpp
> +++ b/src/plugins/coreplugin/editortoolbar.cpp
> @@ -190,6 +190,9 @@ void EditorToolBar::closeView()
> 
>  void EditorToolBar::addEditor(IEditor *editor)
>  {
> +    if (!editor)
> +        return;
> +
>      connect(editor, SIGNAL(changed()), this, SLOT(checkEditorStatus()));
>      QWidget *toolBar = editor->toolBar();
> 
> _______________________________________________
> Qt-creator mailing list
> Qt-creator at trolltech.com
> http://lists.trolltech.com/mailman/listinfo/qt-creator

-- 
Eike Ziller
Software Engineer
Nokia, Qt Development Frameworks

Nokia gate5 GmbH
Firmensitz: Invalidenstr. 117, 10115 Berlin, Germany
Registergericht: Amtsgericht Charlottenburg, Berlin: HRB 106443 B
Umsatzsteueridentifikationsnummer: DE 812 845 193
Geschäftsführer: Dr. Michael Halbherr, Karim Tähtivuori