[Qt-creator] coreplugin/ide_version.h

[eike.ziller at nokia.com]

Hi,
the more "practical" reason for moving the header was that parts in our utils library started to use the information in it (which doesn't work if it's part of the core plugin).

I'd rather not have a copy of the header lying somewhere else.

You could e.g. in your .pro file conditionally set a define
exists($$IDE_BUILD_TREE/src/app/app_version.h):DEFINES+=USE_APP_VERSION_H
and with that find out at compile time which include to use, if you really want to avoid Qt Creator version dependent branches of your plugin, though I'd assume that conditional compilation depending on Qt Creator version can get pretty ugly pretty fast.

Br,
--
Eike Ziller
Principal Software Engineer

Nokia, Qt Development Frameworks

Nokia gate5 GmbH
Firmensitz: Invalidenstr. 117, 10115 Berlin, Germany
Registergericht: Amtsgericht Charlottenburg, Berlin: HRB 106443 B
Umsatzsteueridentifikationsnummer: DE 812 845 193
Geschäftsführer: Dr. Michael Halbherr, Karim Tähtivuori

________________________________________
From: qt-creator-bounces+eike.ziller=nokia.com at qt-project.org [qt-creator-bounces+eike.ziller=nokia.com at qt-project.org] on behalf of ext Konstantin Tokarev [annulen at yandex.ru]
Sent: Monday, November 28, 2011 13:19
To: Poenitz Andre (Nokia-MP-Qt/Berlin)
Cc: qt-creator at qt-project.org
Subject: Re: [Qt-creator] coreplugin/ide_version.h

28.11.2011, 15:16, "Andr Pnitz" <andre.poenitz at nokia.com>:
> On Monday 28 November 2011 11:08:33 ext Konstantin Tokarev wrote:
>
>>  Hi Qt Creator developers,
>>
>>  Recently I've started porting my plugin from Qt Creator 2.3 to 2.4,
>>  and found that coreplugin/ide_version.h was moved to app/app_version.h.
>>
>>  Is there any practical reason behind it?
>
> The version applies to the application, not to the core plugin.

However it was possible to use it for conditional compilation, but moving introduces
even more pain. Would you consider moving it back (or leaving a copy in
coreplugin) if I've submitted a patch?

--
Regards,
Konstantin
_______________________________________________
Qt-creator mailing list
Qt-creator at qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator