[Qt-creator] New terminal plugin for QtCreator

[Nicolas Arnaud-Cormos]

Nice work, looking forward testing it.

I just have a quick look on the code, and have some general remarks (same for 
all 3rd party plugin) - mainly neatpicking:

 * add a PROVIDER line in your .pro file
The PROVIDER is not Nokia, but you :)

 * at least, put this in the .pro file (even if not using it):
## uncomment to build plugin into user config directory
## <localappdata>/plugins/<ideversion>
##    where <localappdata> is e.g.
##    "%LOCALAPPDATA%\Nokia\qtcreator" on Windows Vista and later
##    "$XDG_DATA_HOME/Nokia/qtcreator" or "~/.local/share/Nokia/qtcreator" on 
Linux
##    "~/Library/Application Support/Nokia/Qt Creator" on Mac
#USE_USER_DESTDIR = yes
Allow people to compile the plugin and use it, even if they don't have write 
access to the creator build directory.
I would follow the .pro file generated by the Qt Creator plugin project.

 * you should use a version numbering
As your plugin is outside Qt Creator, it does not follow its numbering scheme.
<plugin name=\"Terminal\" version=\"1.0\" compatVersion=\"1.0\" 
experimental=\"true\">

Thanks,
Nicolas

On Friday 03 February 2012 15:44:08 Adam Treat wrote:
> Hi,
> 
> I've created a terminal plugin for Qt Creator based upon qtermwidget which
> is itself a fork of Konsole and ported to pure Qt.
> 
> Due to the license of Konsole and hence qtermwidget it is in a third party
> project on gitorious for now.
> 
> Feel free to check it out at:
> 
> http://gitorious.org/qt-creator-terminalplugin
> 
> Cheers,
> Adam
> ---------------------------------------------------------------------
> This transmission (including any attachments) may contain confidential
> information, privileged material (including material protected by the
> solicitor-client or other applicable privileges), or constitute non-public
> information. Any use of this information by anyone other than the intended
> recipient is prohibited. If you have received this transmission in error,
> please immediately reply to the sender and delete this information from
> your system. Use, dissemination, distribution, or reproduction of this
> transmission by unintended recipients is not authorized and may be
> unlawful. _______________________________________________
> Qt-creator mailing list
> Qt-creator at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/qt-creator

-- 
Nicolas Arnaud-Cormos | nicolas.arnaud-cormos at kdab.com | Senior Software 
Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions