[Qt-creator] threadnames not called in 2.7.1

[Christoph Mathys]

Found out why it does not work anymore, someone just disabled it in the
source (066efcd6a601e75fa0a1b748ad6d341712507dcc). On a stable version a
perfectly working feature is completely disabled? No comment in the source
or the commit why this was done or anything?!?

So:
diff --git a/src/plugins/debugger/gdb/gdbengine.cpp
b/src/plugins/debugger/gdb/gdbengine.cpp
index 2aa554a..e854ca2 100644
--- a/src/plugins/debugger/gdb/gdbengine.cpp
+++ b/src/plugins/debugger/gdb/gdbengine.cpp
@@ -3778,7 +3778,7 @@ void GdbEngine::handleThreadInfo(const GdbResponse
&response)
                 selectThread(other);
         }
         updateViews(); // Adjust Threads combobox.
-        if (false && m_hasInferiorThreadList &&
debuggerCore()->boolSetting(ShowThreadNames)) {
+        if (m_hasInferiorThreadList &&
debuggerCore()->boolSetting(ShowThreadNames)) {
             postCommand("threadnames " +

debuggerCore()->action(MaximalStackDepth)->value().toByteArray(),
                 Discardable, CB(handleThreadNames));


Christoph


On Wed, May 15, 2013 at 9:25 AM, Christoph Mathys <eraserix at gmail.com>wrote:

> I noticed that threadnames is not called anymore in 2.7.1. This works fine
> on 2.7.0.
>
> Excerpt from the debugger log:
>
> 2.7.1
> 33-interpreter-exec console "bbsetup"
> 34maint print msymbols /tmp/gdb_ns_.Ju1101
> 35-thread-info
> 36-stack-list-frames 0 20
> 37-stack-select-frame 1
> 38bb options:fancy,autoderef,dyntype vars:
> expanded:return,local,watch,inspect typeformats: formats: watchers:
> <Rebuild Watchmodel 1>
>
> 2.7.0
> 33-interpreter-exec console "bbsetup"
> 34maint print msymbols /tmp/gdb_ns_.RT1755
> 35-thread-info
> 36threadnames 20
> 37-stack-list-frames 0 20
> 38-stack-select-frame 1
> 39bb options:fancy,autoderef,dyntype vars:
> expanded:return,local,watch,inspect typeformats: formats: watchers:
> <Rebuild Watchmodel 1>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/qt-creator/attachments/20130523/14bb56a6/attachment.html>