[Qt-creator] [Development] [FYI] on gerrit change retargeting requests

J-P Nurmi jpnurmi at qt.io
Mon Sep 5 23:17:59 CEST 2016


> On 05 Sep 2016, at 19:27, Marc Mutz <marc.mutz at kdab.com> wrote:
> 
> On Monday 05 September 2016 19:20:29 J-P Nurmi wrote:
>>>> On 05 Sep 2016, at 18:53, Marc Mutz <marc.mutz at kdab.com> wrote:
>>>> On Wednesday 31 August 2016 16:12:55 Oswald Buddenhagen wrote:
>>>> with the upcoming qtcon and my subsequent vacation, my availability will
>>>> be rather sporadic, so consider this:
>>>> - i'm not going to do reviews on a regular basis, so it's unwise to just
>>>> 
>>>> add me to them and expect a reaction. send me a direct mail.
>>>> - this recommendation actually applies irrespective of current plans -
>>>> 
>>>>   sometimes i actually want to get some work done instead of just doing
>>>>   reviews. ;)
>>>> 
>>>> - you can also ask frederik gladhorn (fregl)
>>>> 
>>>> generally speaking, send a complete list of change urls, as we can just
>>>> paste that into the script which performs the operation. that's also the
>>>> reason why a single mail (or irc messsage) instead of adding us to n
>>>> reviews is always preferred. please don't give verbal descriptions of
>>>> ranges - somebody has to do the click and paste orgy anyway, and that
>>>> should be you. ;)
>>> 
>>> And please, pretty please, don't _abandon_ changes and resubmit them to a
>>> different branch. _Do_ ask Ossi or Frederik to re-target on the server,
>>> _esp_ if you've already run into half a dozen revisions. Submitting a
>>> new change without the ability to use inter-change diffs is just rude
>>> towards the reviewers.
>> 
>> Let us move our own changes. If you're worried about abuse, downgrade any
>> +2 to +1 on branch change. Problem solved.
> 
> It's not about restricting what a user can do. It's simply missing 
> implementation, and I believe that if it were easy to implement, Ossi would 
> have done it long ago instead of playing retarget-monkey for the rest of us :)

Doing it through the web UI would be a nice bonus, but having access to the same script that is already used by the admins would be good enough for starters.

--
J-P Nurmi


More information about the Qt-creator mailing list