[Qt-creator] Closing pinned files

[André Hartmann]

Hi Mitch,

first of all, I'm no user of this feature, so I had to google it first.
But let me add my opinion:

Seeing the motivation for the feature - to keep files in the Open
Documents list and in the Locator - leads to the question:

Do you really want to forbid to actually close the split containing the
file, or do you just want to keep the file name in the Open Documents list?

If the latter is sufficient, then no user question is needed.

If the split should indeed actually stay open, I'd prefer a yellow info
box at the document top:

   "File is pinned, unpin to close" [Unpin & Close] [X]

as this is the least intrusive way (I really don't like messageboxes).

Another possibility would be to keep the file/split open but show the
next file in the list, until all unpinned files are closed.

But the point I'm with you: pinned files should not close without
confirmation, and therefore I don't think a global setting allowing that
is useful.

Best regards,
André

Am 21.10.22 um 11:45 schrieb EXT Mitch Curtis via Qt-creator:
> … and Close All will be unaffected by this change; it just won’t do
> anything, as before, as it’d be too disruptive.
>
> *From:*Qt-creator <qt-creator-bounces at qt-project.org> *On Behalf Of *EXT
> Mitch Curtis via Qt-creator
> *Sent:* Friday, 21 October 2022 5:43 PM
> *To:* qt-creator at qt-project.org
> *Subject:* [Qt-creator] Closing pinned files
>
> For a while now I’ve been meaning to implement
> https://bugreports.qt.io/browse/QTCREATORBUG-25964
> <https://bugreports.qt.io/browse/QTCREATORBUG-25964> to save myself the
> trouble of accidentally closing pinned files. Currently, pinned files
> are only immune from Close All, but closing via Ctrl+W, context menu,
> etc. will still close them without any prompt.
>
> I’m curious if anyone has opinions on potential solutions to this.
> Should we:
>
> - Ask the user if they want to close the pinned file, defaulting to
> “No”, and with the option to never ask again? To me, allowing the option
> to never ask again seems to defeat the purpose of pinning files; it’s
> too easy to accidentally close pinned files in the future.
>
> - Tell the user that pinned files cannot be closed, and that they have
> to be unpinned first. This option is perhaps less convenient, but in my
> experience, I almost never want to close pinned files, so it seems more
> foolproof. For those that dislike this, perhaps there could be a link to
> the settings to permanently disable it.
>
> What do you think?
>
>
> _______________________________________________
> Qt-creator mailing list
> Qt-creator at qt-project.org
> https://lists.qt-project.org/listinfo/qt-creator