[Qt-interest] changes of QByteArray in 4.4.0

Markus.Klinik at elektrobit.com Markus.Klinik at elektrobit.com
Thu Apr 16 12:36:41 CEST 2009


Hi!

There was a change in QByteArray (src/corelib/tools/qbytearray.cpp) in the
transition from release 4.3.5 to 4.4.0 that produces diffs like this, or
similar, at several places in that file:

-    x = qAtomicSetPtr(&d, x);
-    if (!x->ref.deref())
-         qFree(x);
+    if (!d->ref.deref())
+         qFree(d);
+    d = x;

It looks like a race condition was sorted out, because the pointer assignment
was moved to the end.

Does somebody remember what the problem was? I can't find anything on the
mailing list, in the task tracker or in the Changelog.

Thanks,
Markus


----------------------------------------------------------------
Please note: This e-mail may contain confidential information
intended solely for the addressee. If you have received this
e-mail in error, please do not disclose it to anyone, notify
the sender promptly, and delete the message from your system.
Thank you.



More information about the Qt-interest-old mailing list