[Qt-interest] [Qt-Interest] Problem with QPrinter under X11 - maybe qt bug

Till Oliver Knoll till.oliver.knoll at gmail.com
Mon Oct 17 10:34:29 CEST 2011



Am 17.10.2011 um 09:54 schrieb Zeljko <zeljko at holobit.net>:

> 
> And it's not merged just because commit message is not according to standards 
> ?!?

I don't want to judge on anyone's work here, but who's to blame then?

You can argue about standards whether they make sense or not, but as long as they're there, they're there.

And how hard can it be to follow the rules for a commit message?

I'd rather tend to not trust the code, if even simple things as comments are not right!

And why didn't the author(s) simply fix the comment? I can understand the frustration when you fix a hard bug and then someone says "Your code doesn't follow our guidelines, there's a blank missing here!" - then you might say "Oh fuck it, I'm not going to rewrite my code!" (even though you should)

But a commit comment? Come on...

;)

Cheers, Oliver


More information about the Qt-interest-old mailing list