[Qt-jambi-interest] [RFC PATCH 0/5] Goodbye Version.java

Francis Galiegue fgaliegue at gmail.com
Sun Dec 27 18:44:57 CET 2009


This patch series applies cleanly on top of the community-port-to-4_6
repository, and it solves a longstanding problem: the qt-jambi version was
hardcoded into Java code. With these patches applied, this is no longer the
case.

Apart from the obvious advantage of getting rid of the hardcoded version, this
will also allow us to check, for instance, whether the Qt version we try to
build against is the same than the declared qt-jambi version (this is NOT
implemented in this patch series).

These changes are visible on the "version" branch of the community repository.
You may want to check the git guide if you want to know how to track this branch
(http://qt.gitorious.org/qt-jambi/pages/GitGuide).

Comments welcome!

Francis Galiegue (5):
  [BUILD] Create new file version.properties, source it in setenv.xml
  [BUILD] Copy version.properties into qtjambi source dir on
    initialization
  [BUILD] InitializeTask.java: don't set the qtjambi.version property
    anymore
  [BUILD] com.trolltech.qt.Utilities: use the now included
    version.properties
  [BUILD] qtjambi-utils: get rid of Version.java

 build.xml                                          |    2 +
 .../com/trolltech/tools/ant/InitializeTask.java    |    5 +-
 .../com/trolltech/qt/internal/Version.java         |   89 --------------------
 java/src/qtjambi/com/trolltech/qt/Utilities.java   |   31 ++++---
 setenv.xml                                         |    3 +-
 version.properties                                 |    1 +
 6 files changed, 24 insertions(+), 107 deletions(-)
 delete mode 100644 java/src/qtjambi-util/com/trolltech/qt/internal/Version.java
 create mode 100644 version.properties




More information about the Qt-jambi-interest mailing list