[Releasing] Please add RIM to the review of each commit which changes Qt version

[Vladimir Minenko]

On 07/11/12 11:54, Thiago Macieira wrote:
> On quarta-feira, 7 de novembro de 2012 10.25.28, Vladimir Minenko wrote:
>> Hi,
>>
>> Please add me to the review of each commit which changes Qt version. We need
>> to know when Qt version will be changed on master. Changing Qt version
>> leads to a change in the library names which needs to be configured the
>> device image builds on our side. We need to know about this in advance.
>
> The change in version number happens just after a release, which I'm sure you
> find out very easily.

Not sure... For example, the version 4.8.3 has been changed on master 
around three weeks before an email about the release:

origin/4.8:
commit 1f1ebc29551fe24295ad07307f1a61f98feb0bc1
Date:   Tue Aug 7 03:58:41 2012 -0700

     Changed qt version to 4.8.3

tagged on Sept 09:

 > git log --tags --simplify-by-decoration --pretty="format:%ai %d"
2012-09-06 10:50:43 +0200  (v4.8.3)

and according email has been sent on Sept 17th:
http://comments.gmane.org/gmane.comp.lib.qt.devel/6381

In this particular case we were just about to loose all work done in 
previous 4 weeks going into a release candidate... Just half a day on 
telephone got get it straight again...

a commit to change to 4.8.4 has been submitted on Oct 5th:

commit ceddcb631348f3b150f6e1882fa1a265c503c6df
Date:   Fri Oct 5 05:58:21 2012 -0700

     Changed Qt release version to 4.8.4

     Change-Id: I45f7894f7e79617b6ccb8caa464bbbffaf9dd7b5
     Reviewed-by: Sergio Ahumada <sergio.ahumada at digia.com>
     Reviewed-by: Akseli Salovaara <akseli.salovaara at digia.com>
     Reviewed-by: Lars Knoll <lars.knoll at digia.com>


but 4.8.4 is not released/tagged yet, IMHO. This time, we caught this 
case just by a chance and had to revert that commit, since the 
whitelists for our images were not updated to 4.8.4 in time...

Just some examples!

> But a notice to the ML about the commit changing version numbers would be
> nice.

Yes! Please!

Cheers!

--
Vladimir Minenko
Technical Manager, Qt
+49-160-9898-3242

---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.